-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated release performance notebook to also measure using Nx as imput #2083
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only saw the typo I noted. Ran well for me. no other comments
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #2083 +/- ##
================================================
+ Coverage 73.51% 73.65% +0.14%
================================================
Files 156 154 -2
Lines 10295 10327 +32
================================================
+ Hits 7568 7606 +38
+ Misses 2727 2721 -6
Continue to review full report at Codecov.
|
rerun tests |
2 similar comments
rerun tests |
rerun tests |
Updated build env has compatible NetworkX/SciPy packages. rerun tests |
@gpucibot merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing jumped out, but I was wondering if you really wanted to leave the outputs of your last run for all your cells in place. If not, you could do a "clear all outputs" before saving from jupyter to allow users to start the notebook from a clean state. That would reset the "execution count" for each cell, clear the outputs printing "Reading ./data/...", etc.
@gpucibot merge |
Update the release notebook to produce speedup metrics of using a NetworkX object as the input Graph.