Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated release performance notebook to also measure using Nx as imput #2083

Merged
merged 2 commits into from
Mar 9, 2022
Merged

updated release performance notebook to also measure using Nx as imput #2083

merged 2 commits into from
Mar 9, 2022

Conversation

BradReesWork
Copy link
Member

Update the release notebook to produce speedup metrics of using a NetworkX object as the input Graph.

@BradReesWork BradReesWork requested a review from a team as a code owner February 17, 2022 20:41
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@BradReesWork BradReesWork self-assigned this Feb 17, 2022
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 17, 2022
@BradReesWork BradReesWork added this to the 22.04 milestone Feb 17, 2022
Copy link
Contributor

@acostadon acostadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only saw the typo I noted. Ran well for me. no other comments

notebooks/cugraph_benchmarks/release.ipynb Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #2083 (e5d65a7) into branch-22.04 (3187fbf) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.04    #2083      +/-   ##
================================================
+ Coverage         73.51%   73.65%   +0.14%     
================================================
  Files               156      154       -2     
  Lines             10295    10327      +32     
================================================
+ Hits               7568     7606      +38     
+ Misses             2727     2721       -6     
Impacted Files Coverage Δ
python/cugraph/cugraph/tests/test_doctests.py 98.59% <0.00%> (-1.41%) ⬇️
python/cugraph/cugraph/structure/property_graph.py 96.42% <0.00%> (-0.20%) ⬇️
python/cugraph/cugraph/structure/number_map.py 67.02% <0.00%> (ø)
python/cugraph/cugraph/linear_assignment/lap.py 71.42% <0.00%> (ø)
python/cugraph/cugraph/link_prediction/sorensen.py 85.18% <0.00%> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 89.65% <0.00%> (ø)
...raph/structure/graph_implementation/simpleGraph.py 74.30% <0.00%> (ø)
python/cugraph/cugraph/tests/test_raft.py
python/cugraph/cugraph/dask/common/__init__.py
...ython/cugraph/cugraph/tests/test_property_graph.py 96.09% <0.00%> (+0.04%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3187fbf...e5d65a7. Read the comment docs.

@BradReesWork
Copy link
Member Author

rerun tests

2 similar comments
@BradReesWork
Copy link
Member Author

rerun tests

@BradReesWork
Copy link
Member Author

rerun tests

@rlratzel
Copy link
Contributor

rlratzel commented Mar 9, 2022

Updated build env has compatible NetworkX/SciPy packages.

rerun tests

@BradReesWork
Copy link
Member Author

@gpucibot merge

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumped out, but I was wondering if you really wanted to leave the outputs of your last run for all your cells in place. If not, you could do a "clear all outputs" before saving from jupyter to allow users to start the notebook from a clean state. That would reset the "execution count" for each cell, clear the outputs printing "Reading ./data/...", etc.

@BradReesWork
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1b0894d into rapidsai:branch-22.04 Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants