Allow PropertyGraph default_edge_weight to be used to add an edge weight value on extracted Graphs even when a weight property wasn't specified
#2071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wrapping in a class wrapper instead of a function (where the return type is no longer a class type, and isinstance() unexpectedly fails). Added tests.
…4-propgraph_updates
…hanged num_vertices property impl for better performance, added get_vertices(), allow a None type_name for add_*_data(), updated docstrings, changed the edge_data added to Graphs to be a DataFrame for efficiency, added tests and benchmarks, refactored and added test fixtures, updated pytest.ini for new benchmarks.
…4-propgraph_updates
…4-propgraph_updates
…4-propgraph_updates
… extracted Graphs even when a weight property wasn't specified.
rlratzel
added
improvement
BradReesWork
approved these changes
Feb 14, 2022
…e passed in and not column/series objects.
acostadon
approved these changes
Feb 14, 2022
Yes, thanks, I changed that to make it more obvious that it's a name and not an obj. I'll update the PR description too. |
jnke2016
approved these changes
Feb 15, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows a Graph to be extracted with a default weight value even if an edge property for a weight is not specified.
This PR also changes the arg names that are intended to take column name strings to make it more obvious that strings are expected and not Column/Series objects.