-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce peak memory requirement in graph creation (part 1/2) #2070
Merged
rapids-bot
merged 13 commits into
rapidsai:branch-22.04
from
seunghwak:enh_mem_footprint
Feb 22, 2022
Merged
Reduce peak memory requirement in graph creation (part 1/2) #2070
rapids-bot
merged 13 commits into
rapidsai:branch-22.04
from
seunghwak:enh_mem_footprint
Feb 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunghwak
added
3 - Ready for Review
improvement
Improvement / enhancement to an existing function
breaking
Breaking change
labels
Feb 13, 2022
…dgelist to pass mem_frugal=true to limit the maximum allocation chunk size to avoid malloc failure due to fragmentation with the pool allocator
…uctor to limit peak memory usage
seunghwak
changed the title
Reduce peak memory requirement in graph creation
Reduce peak memory requirement in graph creation (part 1/2)
Feb 16, 2022
ChuckHastings
approved these changes
Feb 17, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #2070 +/- ##
================================================
+ Coverage 73.54% 73.64% +0.09%
================================================
Files 156 156
Lines 10316 10332 +16
================================================
+ Hits 7587 7609 +22
+ Misses 2729 2723 -6
Continue to review full report at Codecov.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, graph creation requires roughly edge data size * 2 + alpha (if we can destroy the input edge data and reclaim the memory, * 3 if the input edge data cannot be destroyed). This PR cuts this to edge data size * 1.5 + alpha.
This is a breaking PR for projects using functions under https://github.com/rapidsai/cugraph/blob/branch-22.04/cpp/include/cugraph/utilities/shuffle_comm.cuh (@aschaffer You may be affected).
There will be a follow-up PR further optimizing memory footprint. Wrapping up this PR to avoid creating a giant PR.