PropertyGraph updates: added features for DGL, improved extract_subgraph() and num_vertices performance
#2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wrapping in a class wrapper instead of a function (where the return type is no longer a class type, and isinstance() unexpectedly fails). Added tests.
…4-propgraph_updates
…hanged num_vertices property impl for better performance, added get_vertices(), allow a None type_name for add_*_data(), updated docstrings, changed the edge_data added to Graphs to be a DataFrame for efficiency, added tests and benchmarks, refactored and added test fixtures, updated pytest.ini for new benchmarks.
…4-propgraph_updates
rlratzel
added
improvement
|
Could potentially be a cudf issue with rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #2056 +/- ##
===============================================
Coverage ? 73.62%
===============================================
Files ? 155
Lines ? 10172
Branches ? 0
===============================================
Hits ? 7489
Misses ? 2683
Partials ? 0 Continue to review full report at Codecov.
|
BradReesWork
approved these changes
Feb 3, 2022
|
@gpucibot merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates needed for adding new features for DGL, improving
extract_subgraph()andnum_verticesperformance:PropertyGraphcolumn name constants public for use by clientsnum_verticesproperty impl for better performanceget_vertices()Nonetype_name foradd_*_data()edge_dataadded to Graphs to be a DataFrame for efficiencypytest.inifor new benchmarksTested by ensuring all new tests added passed, benchmarks ran, and existing
test_graph_store.pytests still passed.