Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Louvain hang in multi-GPU testing #2028

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

seunghwak
Copy link
Contributor

If the CSR + DCSR hybrid format is used to store a graph, the size of the offset array can be smaller than the number of vertices + 1. The previous code didn't consider this in calling cub's segmented sort. This PR fixes this mistake.

@seunghwak seunghwak requested a review from a team as a code owner January 20, 2022 20:58
@seunghwak seunghwak added 2 - In Progress bug Something isn't working non-breaking Non-breaking change labels Jan 20, 2022
@seunghwak seunghwak changed the title [WIP][skip-ci] Fix Louvain hang in multi-GPU testing Fix Louvain hang in multi-GPU testing Jan 20, 2022
@seunghwak
Copy link
Contributor Author

rerun tests

@seunghwak
Copy link
Contributor Author

FYI: @ChuckHastings @jnke2016

@seunghwak seunghwak self-assigned this Jan 20, 2022
@seunghwak
Copy link
Contributor Author

@BradReesWork This is a bug fix, so I think this should go to this release.

@seunghwak seunghwak added this to the 22.02 milestone Jan 20, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@20a6d54). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #2028   +/-   ##
===============================================
  Coverage                ?   70.75%           
===============================================
  Files                   ?      142           
  Lines                   ?     8861           
  Branches                ?        0           
===============================================
  Hits                    ?     6270           
  Misses                  ?     2591           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20a6d54...08c2a30. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a2b8d5a into rapidsai:branch-22.02 Jan 21, 2022
@seunghwak seunghwak deleted the bug_louvain_hang branch January 27, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants