Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix call to getDeviceAttribute following API change in RMM. #2008

Merged
merged 5 commits into from
Jan 20, 2022
Merged

Fix call to getDeviceAttribute following API change in RMM. #2008

merged 5 commits into from
Jan 20, 2022

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Jan 11, 2022 •
edited
Loading

Please do not merge until rapidsai/rmm#930 is merged.

For the reasons described in that PR, this API has changed to accept a cuda.cudart.cudaDeviceAttr object, cuda being the official CUDA Python bindings package.

@shwina shwina marked this pull request as ready for review January 11, 2022 14:59
@shwina shwina requested a review from a team as a code owner January 11, 2022 14:59
@BradReesWork BradReesWork added 5 - Merge After Dependencies improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 11, 2022
@BradReesWork BradReesWork added this to the 22.02 milestone Jan 11, 2022
@shwina shwina requested a review from a team as a code owner January 14, 2022 15:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022 •
edited
Loading

Codecov Report

Merging #2008 (45ba02e) into branch-22.02 (6883cc1) will increase coverage by 0.59%.
The diff coverage is 100.00%.

❗ Current head 45ba02e differs from pull request most recent head cb42a67. Consider uploading reports for the commit cb42a67 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #2008      +/-   ##
================================================
+ Coverage         70.16%   70.75%   +0.59%     
================================================
  Files               142      142              
  Lines              8671     8861     +190     
================================================
+ Hits               6084     6270     +186     
- Misses             2587     2591       +4
Impacted Files Coverage Δ
python/cugraph/cugraph/utilities/utils.py 70.37% <100.00%> (+0.18%) ⬆️
python/cugraph/cugraph/tests/test_ecg.py 100.00% <0.00%> (ø)
python/cugraph/cugraph/tests/test_paths.py 100.00% <0.00%> (ø)
python/cugraph/cugraph/tests/test_egonet.py 100.00% <0.00%> (ø)
python/pylibcugraph/pylibcugraph/_version.py 0.00% <0.00%> (ø)
python/cugraph/cugraph/tests/test_renumber.py 100.00% <0.00%> (ø)
python/cugraph/cugraph/tests/test_wjaccard.py 100.00% <0.00%> (ø)
python/cugraph/cugraph/tests/test_hungarian.py 100.00% <0.00%> (ø)
python/cugraph/cugraph/tests/test_wsorensen.py 100.00% <0.00%> (ø)
python/cugraph/cugraph/tests/dask/mg_context.py 0.00% <0.00%> (ø)
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6883cc1...cb42a67. Read the comment docs.

@BradReesWork BradReesWork added the DO NOT MERGE Hold off on merging; see PR for details label Jan 18, 2022
ajschmidt8
ajschmidt8 approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@shwina
Copy link
Contributor Author

shwina commented Jan 19, 2022

rerun tests

2 similar comments
@galipremsagar
Copy link
Contributor

rerun tests

@shwina
Copy link
Contributor Author

shwina commented Jan 20, 2022

rerun tests

@BradReesWork BradReesWork removed DO NOT MERGE Hold off on merging; see PR for details 5 - Merge After Dependencies labels Jan 20, 2022
@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 487143c into rapidsai:branch-22.02 Jan 20, 2022
@ChuckHastings
Copy link
Collaborator

@gpucibot merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.02
Development

Successfully merging this pull request may close these issues.
7 participants
@shwina @codecov-commenter @galipremsagar @rlratzel @ChuckHastings @ajschmidt8 @BradReesWork