Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop fa2 cpu code #2007

Merged
merged 5 commits into from
Jan 18, 2022
Merged

drop fa2 cpu code #2007

merged 5 commits into from
Jan 18, 2022

Conversation

BradReesWork
Copy link
Member

update the ForceAtlas notebook to not use fa2 python package

@BradReesWork BradReesWork requested a review from a team as a code owner January 10, 2022 23:56
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@BradReesWork BradReesWork added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 10, 2022
@BradReesWork BradReesWork added this to the 22.02 milestone Jan 10, 2022
@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

ChuckHastings commented on 2022-01-11T00:16:57Z
----------------------------------------------------------------

Misspellings here:

"THat" => "That"

"requierd" => "required"

"unmainated" => "unmaintained"

@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

ChuckHastings commented on 2022-01-11T00:16:58Z
----------------------------------------------------------------

Do we want this error in saved in the notebook?

ChuckHastings
ChuckHastings requested changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor edits/questions.

@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@6883cc1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #2007   +/-   ##
===============================================
  Coverage                ?   70.75%           
===============================================
  Files                   ?      142           
  Lines                   ?     8860           
  Branches                ?        0           
===============================================
  Hits                    ?     6269           
  Misses                  ?     2591           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6883cc1...9f8286e. Read the comment docs.

@BradReesWork
Copy link
Member Author

Sorry, pushed the wrong version.

ChuckHastings
ChuckHastings approved these changes Jan 13, 2022
View reviewed changes
Copy link
Collaborator

@ChuckHastings ChuckHastings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rlratzel
rlratzel approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One suggestion (optional): instead of the

start = time.time()
...
elapsed = time.time() - start

you could use the %%time or %%timeit cell magic.

@BradReesWork
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit efbff09 into rapidsai:branch-22.02 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.02
Development

Successfully merging this pull request may close these issues.
4 participants
@BradReesWork @codecov-commenter @rlratzel @ChuckHastings