Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency in C++ test case names and add R-mat tests to graph coarsening #1976

Merged
merged 3 commits into from
Dec 4, 2021
Merged

Improve consistency in C++ test case names and add R-mat tests to graph coarsening #1976

merged 3 commits into from
Dec 4, 2021

Conversation

seunghwak
Copy link
Contributor

  • In test case names, we were mixing Transposed/Untransposed and TransposeFalse/TransposeTrue. Updated to use TransposeFalse/TransposeTrue consistently.
  • Add R-mat tests to the C++ graph coarsening test suite.

@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 2, 2021
@seunghwak seunghwak added this to the 22.02 milestone Dec 2, 2021
@seunghwak seunghwak self-assigned this Dec 2, 2021
@seunghwak seunghwak requested a review from a team as a code owner December 2, 2021 19:04
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@2e9319a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #1976   +/-   ##
===============================================
  Coverage                ?   70.28%           
===============================================
  Files                   ?      143           
  Lines                   ?     8922           
  Branches                ?        0           
===============================================
  Hits                    ?     6271           
  Misses                  ?     2651           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e9319a...428a248. Read the comment docs.

@seunghwak seunghwak mentioned this pull request Dec 3, 2021
Merged
2 tasks
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b7d63bb into rapidsai:branch-22.02 Dec 4, 2021
@seunghwak seunghwak deleted the enh_coarsen_graph_rmat_test branch January 27, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@kaatish kaatish Awaiting requested review from kaatish

Assignees

@seunghwak seunghwak

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.02
Development

Successfully merging this pull request may close these issues.
4 participants
@seunghwak @codecov-commenter @BradReesWork @ChuckHastings