Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22.02 dep fix #1974

Merged
merged 9 commits into from
Dec 2, 2021
Merged

22.02 dep fix #1974

merged 9 commits into from
Dec 2, 2021

Conversation

BradReesWork
Copy link
Member

address cuDF deprecation of "to_array".
some cleanup

@BradReesWork BradReesWork requested review from a team as code owners December 1, 2021 19:19
@BradReesWork BradReesWork added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 1, 2021
@BradReesWork BradReesWork added this to the 22.02 milestone Dec 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.02@550685c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.02    #1974   +/-   ##
===============================================
  Coverage                ?   70.50%           
===============================================
  Files                   ?      142           
  Lines                   ?     8880           
  Branches                ?        0           
===============================================
  Hits                    ?     6261           
  Misses                  ?     2619           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 550685c...f7f774f. Read the comment docs.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed a minor typo.

SOURCEBUILD.md Outdated Show resolved Hide resolved
@@ -82,6 +86,9 @@ python/_external_repositories/

# created by Dask tests
python/dask-worker-space
python/cugraph/dask-worker-space
python/cugraph/cugraph/dask-worker-space
python/cugraph/cugraph/tests/dask-worker-space
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 3 are helpful because I won't have to exclude them myself before pushing a commit

Co-authored-by: Rick Ratzel <[email protected]>
@BradReesWork
Copy link
Member Author

rerun tests

@BradReesWork
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8c265ec into rapidsai:branch-22.02 Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants