Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accounting for raft::random detail changes #1937

Merged
merged 5 commits into from
Nov 12, 2021
Merged

Accounting for raft::random detail changes #1937

merged 5 commits into from
Nov 12, 2021

Conversation

divyegala
Copy link
Member

Depends on rapidsai/raft#356

@divyegala divyegala requested a review from a team as a code owner November 9, 2021 18:50
@rlratzel rlratzel added Fix non-breaking Non-breaking change labels Nov 9, 2021
@divyegala divyegala requested a review from a team as a code owner November 9, 2021 18:53
@rlratzel rlratzel added the improvement Improvement / enhancement to an existing function label Nov 9, 2021
rlratzel
rlratzel approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just confirmed with @divyegala that the fork and version updates to get_raft.cmake are temporary, and will be reverted after rapidsai/raft#356 is merged.

@divyegala
Copy link
Member Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@2770c87). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1937   +/-   ##
===============================================
  Coverage                ?   70.35%           
===============================================
  Files                   ?      143           
  Lines                   ?     8903           
  Branches                ?        0           
===============================================
  Hits                    ?     6264           
  Misses                  ?     2639           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2770c87...2f93d49. Read the comment docs.

@rlratzel
Copy link
Contributor

rerun tests
This appears to be a problem related to conda installing an old cupy package. I believe the issue has since been resolved.

@seunghwak seunghwak mentioned this pull request Nov 11, 2021
Closed
seunghwak
seunghwak reviewed Nov 11, 2021
View reviewed changes
cpp/src/detail/shuffle_wrappers.cu Outdated
@@ -18,7 +18,7 @@
#include <cugraph/partition_manager.hpp>
#include <cugraph/utilities/shuffle_comm.cuh>

#include <raft/random/rng.cuh>
#include <raft/random/rng.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one can be deleted, this file does not use raft's random number generator.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

seunghwak
seunghwak approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me except for the unnecessary include statement in shuffle_wrappers.cu.

@seunghwak seunghwak mentioned this pull request Nov 11, 2021
Merged
2 tasks
@seunghwak seunghwak mentioned this pull request Nov 11, 2021
Merged
3 tasks
@rlratzel
Copy link
Contributor

rlratzel commented Nov 12, 2021 •
edited
Loading

rerun tests

CPU build had:

conda.CondaMultiError: Downloaded bytes did not match Content-Length
url: https://conda.anaconda.org/nvidia/linux-64/cudatoolkit-11.2.72-h2bc3f7f_0.tar.bz2
target_path: /opt/conda/envs/rapids/pkgs/cudatoolkit-11.2.72-h2bc3f7f_0.tar.bz2

and retry failed, so I wonder if the uploaded package is corrupted?

edit: CI checks all passed after this rerun, so the package is likely okay.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fda2466 into rapidsai:branch-21.12 Nov 12, 2021
@bdice bdice mentioned this pull request Nov 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@divyegala @codecov-commenter @rlratzel @BradReesWork @ChuckHastings @seunghwak