Fix metadata mismatch #1920
Merged
Fix metadata mismatch #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #1920 +/- ##
===============================================
Coverage ? 70.85%
===============================================
Files ? 143
Lines ? 9366
Branches ? 0
===============================================
Hits ? 6636
Misses ? 2730
Partials ? 0 Continue to review full report at Codecov.
|
BradReesWork
added
3 - Ready for Review
improvement
BradReesWork
approved these changes
Nov 2, 2021
| if not isinstance(src_col_names, list): | ||
| src_col_names = [src_col_names] | ||
| dst_col_names = [dst_col_names] | ||
|
|
||
| id_type = df[src_col_names[0]].dtype | ||
| renumber_map = NumberMap(id_type=id_type) | ||
| if type(df) is cudf.DataFrame: |
rlratzel
approved these changes
Nov 2, 2021
ChuckHastings
approved these changes
Nov 2, 2021
|
rerun tests |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change causes some of the dask's partition dataframe to have different types.
This PR ensures the dask partition after renumbering are the same as the initial dask dataframe
Note: Still looking for the root cause of this change