Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add raft ops for reduce_v and transform_reduce_v #1902

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Add raft ops for reduce_v and transform_reduce_v #1902

merged 2 commits into from
Oct 27, 2021

Conversation

kaatish
Copy link
Collaborator

@kaatish kaatish commented Oct 24, 2021 •
edited
Loading

reduce_v and transform_reduce_v support raft::comms::op_t as a parameter. Tests have been updated accordingly.
Fixes #1903

@kaatish kaatish requested a review from a team as a code owner October 24, 2021 05:08
@kaatish kaatish self-assigned this Oct 24, 2021
@kaatish kaatish added this to the 21.12 milestone Oct 24, 2021
@kaatish kaatish added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@61b99df). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1902   +/-   ##
===============================================
  Coverage                ?   70.13%           
===============================================
  Files                   ?      143           
  Lines                   ?     8812           
  Branches                ?        0           
===============================================
  Hits                    ?     6180           
  Misses                  ?     2632           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b99df...5cc7522. Read the comment docs.

seunghwak
seunghwak approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!!

We may consider dropping PROD support at this moment.

cpp/tests/prims/mg_reduce_v.cu Outdated Show resolved Hide resolved
@ChuckHastings
Copy link
Collaborator

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2f3ed7a into rapidsai:branch-21.12 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@kaatish kaatish

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
21.12
Development

Successfully merging this pull request may close these issues.

[ENH] Add support for raft comms operators in reduce_v and transform_reduce_v
5 participants
@kaatish @codecov-commenter @ChuckHastings @BradReesWork @seunghwak