-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Nx and Graph/DiGraph issues #1882
Fixing Nx and Graph/DiGraph issues #1882
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #1882 +/- ##
================================================
+ Coverage 70.11% 70.30% +0.18%
================================================
Files 143 143
Lines 8827 8863 +36
================================================
+ Hits 6189 6231 +42
+ Misses 2638 2632 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just had some suggestions below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. just few comments
@gpucibot merge |
Fixed a number of issues with conversion of Nx directed graphs. Fix nx tests, fixed issues with using new Graph(directed=true) but checking for DiGraph