Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary explicit template instantiation #1878

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

seunghwak
Copy link
Contributor

No need to instantiate for vertex_t=int64_t and edge_t=int32_t

@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 12, 2021
@seunghwak seunghwak requested a review from a team as a code owner October 12, 2021 16:03
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2021

Codecov Report

Merging #1878 (2f67c30) into branch-21.12 (5cc7799) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-21.12    #1878   +/-   ##
=============================================
  Coverage         70.11%   70.11%           
=============================================
  Files               143      143           
  Lines              8827     8827           
=============================================
  Hits               6189     6189           
  Misses             2638     2638           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cc7799...2f67c30. Read the comment docs.

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b4a98c8 into rapidsai:branch-21.12 Oct 12, 2021
@seunghwak seunghwak deleted the enh_instantiation branch October 20, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants