-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed NetworkX requirement for type checks, fixed docstring, added new docstrings, import cleanups #1853
Removed NetworkX requirement for type checks, fixed docstring, added new docstrings, import cleanups #1853
Conversation
…or Nx types without requiring Nx.
…0-doc_and_nx_import_fix
… type checking code, added docstrings for pylibcugraph.CC functions.
Codecov Report
@@ Coverage Diff @@
## branch-21.10 #1853 +/- ##
================================================
+ Coverage 69.59% 70.08% +0.49%
================================================
Files 143 143
Lines 8675 8819 +144
================================================
+ Hits 6037 6181 +144
Misses 2638 2638
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
…rt in BC for consistency.
@gpucibot merge |
import_optional
to useimportlib
instead, and returnMissingModule
instances for easier error reporting.rmat
docstring [DOC] RMAT documentation example is badly formatted. #1807pylibcugraph
*_connected_components
APIs. [FEA] initialpylibcugraph
support #1782Tested changes to optional import and type checking code by uninstalling
NetworkX
, observing the failure shown in #1851, applying change, then testing to observe the same script runs to completion without Nx installed.closes #1851
closes #1807
closes #1782