Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compiler version checks to cmake to fail early #1836

Merged

Conversation

ChuckHastings
Copy link
Collaborator

Closes #1677

We require gcc 9.3 and nvcc 11.0 from a feature perspective. This change forces make to validate that someone building cugraph has these versions.

@ChuckHastings ChuckHastings requested a review from a team as a code owner September 22, 2021 19:10
@ChuckHastings ChuckHastings self-assigned this Sep 22, 2021
@ChuckHastings ChuckHastings added this to the 21.10 milestone Sep 22, 2021
@ChuckHastings ChuckHastings added the improvement Improvement / enhancement to an existing function label Sep 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #1836 (dc1a3c7) into branch-21.10 (bf64c2c) will increase coverage by 9.72%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #1836      +/-   ##
================================================
+ Coverage         59.85%   69.57%   +9.72%     
================================================
  Files                77      139      +62     
  Lines              3547     8645    +5098     
================================================
+ Hits               2123     6015    +3892     
- Misses             1424     2630    +1206     
Impacted Files Coverage Δ
python/cugraph/proto/structure/bicliques.py
python/cugraph/dask/centrality/katz_centrality.py
python/cugraph/proto/components/scc.py
python/cugraph/linear_assignment/lap.py
python/cugraph/link_analysis/__init__.py
python/cugraph/community/ktruss_subgraph.py
python/cugraph/community/triangle_count.py
python/cugraph/link_analysis/hits.py
python/cugraph/community/louvain.py
python/cugraph/dask/community/louvain.py
... and 206 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cabcd0...dc1a3c7. Read the comment docs.

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 677b9f3 into rapidsai:branch-21.10 Sep 22, 2021
@ChuckHastings ChuckHastings deleted the fea_compiler_version_checks branch February 1, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Update CmakeLists.txt to update gcc & nvcc versions
3 participants