Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Pylibcugraph connected components #1800

Merged
merged 12 commits into from
Sep 3, 2021

Conversation

Iroy30
Copy link
Contributor

@Iroy30 Iroy30 commented Aug 31, 2021

Adds initial support for pylibcugraph.strongly_connected_components() and pylibcugraph.weakly_connected_components()

This is still the first phase for pylibcugraph, where future phases will see the current cython code in cugraph replaced with a call to pylibcugraph from python. For now, they're still independent cython extensions.

Also added unit tests and updated ci testing script to call the new pylibcugraph tests.

@Iroy30 Iroy30 requested review from a team as code owners August 31, 2021 21:31
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 2, 2021
@rlratzel rlratzel linked an issue Sep 2, 2021 that may be closed by this pull request
9 tasks
@rlratzel rlratzel removed their assignment Sep 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

Codecov Report

Merging #1800 (31d7fee) into branch-21.10 (bf64c2c) will increase coverage by 9.97%.
The diff coverage is n/a.

❗ Current head 31d7fee differs from pull request most recent head f3e27fa. Consider uploading reports for the commit f3e27fa to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #1800      +/-   ##
================================================
+ Coverage         59.85%   69.83%   +9.97%     
================================================
  Files                77      139      +62     
  Lines              3547     8592    +5045     
================================================
+ Hits               2123     6000    +3877     
- Misses             1424     2592    +1168     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/_version.py 44.80% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 90.00% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 89.47% <ø> (ø)
python/cugraph/cugraph/comms/comms.py 34.52% <ø> (ø)
python/cugraph/cugraph/community/__init__.py 70.37% <ø> (ø)
python/cugraph/cugraph/community/ecg.py 100.00% <ø> (ø)
python/cugraph/cugraph/community/egonet.py 92.30% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 84.37% <ø> (ø)
... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b89eb18...f3e27fa. Read the comment docs.

Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@rlratzel
Copy link
Contributor

rlratzel commented Sep 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 31317ef into rapidsai:branch-21.10 Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] initial pylibcugraph support
5 participants