Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Bug dask cudf personalization #1764

Merged
merged 6 commits into from
Aug 12, 2021
Merged

[REVIEW] Bug dask cudf personalization #1764

merged 6 commits into from
Aug 12, 2021

Conversation

Iroy30
Copy link
Contributor

@Iroy30 Iroy30 commented Aug 6, 2021 •
edited
Loading

fixes pagerank error when personalization is passed

@Iroy30 Iroy30 requested a review from a team as a code owner August 6, 2021 16:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.10@e1787ce). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.10    #1764   +/-   ##
===============================================
  Coverage                ?   59.63%           
===============================================
  Files                   ?       77           
  Lines                   ?     3535           
  Branches                ?        0           
===============================================
  Hits                    ?     2108           
  Misses                  ?     1427           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1787ce...4b5bd86. Read the comment docs.

@BradReesWork BradReesWork added bug Something isn't working non-breaking Non-breaking change labels Aug 9, 2021
@BradReesWork BradReesWork added this to the 21.10 milestone Aug 9, 2021
jnke2016
jnke2016 reviewed Aug 10, 2021
View reviewed changes
Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

rlratzel
rlratzel approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor request.

python/cugraph/dask/link_analysis/pagerank.py Show resolved Hide resolved
rlratzel
rlratzel requested changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(oops, I accidentally selected "approve" instead of "request changes' for the request for comments)

@Iroy30
Copy link
Contributor Author

Iroy30 commented Aug 11, 2021

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 35c53f7 into rapidsai:branch-21.10 Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnke2016 jnke2016 jnke2016 left review comments

@BradReesWork BradReesWork BradReesWork approved these changes

@rlratzel rlratzel rlratzel approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
21.10
Development

Successfully merging this pull request may close these issues.
5 participants
@Iroy30 @codecov-commenter @BradReesWork @rlratzel @jnke2016