fixing symmetrize_ddf #1686
Merged
fixing symmetrize_ddf #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #1686 +/- ##
================================================
- Coverage 59.77% 59.75% -0.02%
================================================
Files 80 80
Lines 3540 3546 +6
================================================
+ Hits 2116 2119 +3
- Misses 1424 1427 +3
Continue to review full report at Codecov.
|
BradReesWork
added
3 - Ready for Review
improvement
BradReesWork
approved these changes
Jun 25, 2021
ChuckHastings
approved these changes
Jun 26, 2021
rlratzel
approved these changes
Jun 28, 2021
|
cc: @rjzamora It would be great if you could confirm that the use of |
rjzamora
reviewed
Jun 29, 2021
Comment on lines
+143
to
+146
| result = ddf.shuffle(on=[ | ||
| src_name, dst_name], ignore_index=True, npartitions=num_workers) | ||
| result = result.map_partitions(lambda x: x.groupby( | ||
| by=[src_name, dst_name], as_index=False).min().reset_index(drop=True)) |
There was a problem hiding this comment.
@ayushdg - This looks reasonable to me :)
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the function symmetrizing the dask dataframe