Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct install path for include folder to avoid double nesting #1630

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented May 27, 2021

Similar to rapidsai/cuml#3901.

After #1491 and #rapids-cmake and #1585, now at install time, the cugraph headers are being nested into path/to/env/include/cugraph/cugraph instead of just path/to/env/include/cugraph/. This, as far as I'm aware, is unintentional and unlike the rest of RAPIDS projects (cuDF, RMM and cuML).

cc @trxcllnt @robertmaynard

@dantegd dantegd requested a review from a team as a code owner May 27, 2021 15:24
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@0859228). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5a52817 differs from pull request most recent head 2faa622. Consider uploading reports for the commit 2faa622 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #1630   +/-   ##
===============================================
  Coverage                ?   59.75%           
===============================================
  Files                   ?       79           
  Lines                   ?     3484           
  Branches                ?        0           
===============================================
  Hits                    ?     2082           
  Misses                  ?     1402           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0859228...2faa622. Read the comment docs.

@ChuckHastings ChuckHastings added non-breaking Non-breaking change Fix labels May 28, 2021
@rlratzel rlratzel added bug Something isn't working and removed Fix labels May 28, 2021
@seunghwak seunghwak added 3 - Ready for Review and removed bug Something isn't working labels May 28, 2021
@rlratzel rlratzel added bug Something isn't working and removed Fix labels May 28, 2021
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BradReesWork BradReesWork added this to the 21.06 milestone Jun 1, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e80a696 into rapidsai:branch-21.06 Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants