Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up nullptr cuda_stream_view arguments #1504

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Clean up nullptr cuda_stream_view arguments #1504

merged 2 commits into from
Apr 2, 2021

Conversation

hlinsen
Copy link
Contributor

@hlinsen hlinsen commented Apr 2, 2021

Cugraph fix for: #1499

@hlinsen hlinsen requested a review from a team as a code owner April 2, 2021 08:02
@BradReesWork BradReesWork added Fix improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 2, 2021
@BradReesWork BradReesWork added this to the 0.19 milestone Apr 2, 2021
@BradReesWork
Copy link
Member

rerun tests

2 similar comments
@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

rerun tests

afender
afender approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Hugo 👍

@afender
Copy link
Member

afender commented Apr 2, 2021

We need to merge #1498 before rerunning tests

@hlinsen hlinsen changed the base branch from branch-0.20 to branch-0.19 April 2, 2021 14:48
@hlinsen hlinsen requested a review from a team as a code owner April 2, 2021 14:48
@hlinsen hlinsen requested review from a team as code owners April 2, 2021 14:49
@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d1ec7ac into rapidsai:branch-0.19 Apr 2, 2021
@BradReesWork BradReesWork linked an issue Apr 6, 2021 that may be closed by this pull request
[BUG] RMM cuda_stream_view breaking change #1499
Closed
@hlinsen hlinsen deleted the rmm-fix branch April 15, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afender afender afender approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees

@hlinsen hlinsen

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
0.19
Development

Successfully merging this pull request may close these issues.

[BUG] RMM cuda_stream_view breaking change
3 participants
@hlinsen @BradReesWork @afender