Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS BFS python APIs + EgoNet updates #1469

Merged
merged 8 commits into from
Mar 26, 2021
Merged

Conversation

afender
Copy link
Member

@afender afender commented Mar 17, 2021

There are various things in this PR.

Multi-Seed (MS) BFS:

  • API tentative
  • Saving research on memory feasability helper function (not in production)
  • Saving research on running the current BFS concurrently with streams and threads for analysis perf comparison (not in production)

EgoNet:

  • Multithreading in EgoNet which deserializes execution and comes with mild performance improvements on large sizes
  • Some cleanup

@afender afender added Research improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 17, 2021
@afender afender requested review from a team as code owners March 17, 2021 22:33
@BradReesWork BradReesWork added this to the 0.19 milestone Mar 18, 2021
@BradReesWork BradReesWork requested a review from aschaffer March 23, 2021 18:42
@@ -0,0 +1,276 @@
# Copyright (c) 2021, NVIDIA CORPORATION.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want a test for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that it is not been implemented but exposed, is that right?
In that case, we could either raise error or not expose it to user

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it is just the API proposal. I can raise an error.

@codecov-io
Copy link

Codecov Report

Merging #1469 (df0609a) into branch-0.19 (128abf0) will decrease coverage by 2.51%.
The diff coverage is 30.12%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #1469      +/-   ##
===============================================
- Coverage        60.72%   58.20%   -2.52%     
===============================================
  Files               70       71       +1     
  Lines             3132     3283     +151     
===============================================
+ Hits              1902     1911       +9     
- Misses            1230     1372     +142     
Impacted Files Coverage Δ
python/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/traversal/ms_bfs.py 11.11% <11.11%> (ø)
python/cugraph/utilities/utils.py 69.23% <64.28%> (-2.43%) ⬇️
python/cugraph/traversal/__init__.py 100.00% <100.00%> (ø)
python/cugraph/dask/common/part_utils.py 20.66% <0.00%> (-0.18%) ⬇️
python/cugraph/community/egonet.py 91.42% <0.00%> (ø)
python/cugraph/dask/community/louvain.py 33.33% <0.00%> (ø)
python/cugraph/tree/minimum_spanning_tree.py 85.36% <0.00%> (ø)
python/cugraph/dask/structure/renumber.py
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 128abf0...df0609a. Read the comment docs.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1f0f14e into rapidsai:branch-0.19 Mar 26, 2021
@afender afender deleted the ms_api branch April 5, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants