Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-label PRs based on their content [skip-ci] #1358

Merged
merged 6 commits into from
Feb 2, 2021

Conversation

jolorunyomi
Copy link
Contributor

@jolorunyomi jolorunyomi commented Jan 25, 2021

This PR adds the GitHub action PR Labeler to auto-label PRs based on their content.

Labeling is managed with a configuration file .github/labeler.yml using the following options.

@jolorunyomi jolorunyomi marked this pull request as ready for review January 25, 2021 13:43
@jolorunyomi jolorunyomi requested a review from a team as a code owner January 25, 2021 13:43
@codecov-io
Copy link

codecov-io commented Jan 25, 2021

Codecov Report

Merging #1358 (fa4b3f3) into branch-0.18 (2fb0725) will decrease coverage by 1.42%.
The diff coverage is 57.84%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.18    #1358      +/-   ##
===============================================
- Coverage        60.38%   58.95%   -1.43%     
===============================================
  Files               67       67              
  Lines             3029     3060      +31     
===============================================
- Hits              1829     1804      -25     
- Misses            1200     1256      +56     
Impacted Files Coverage Δ
python/cugraph/centrality/__init__.py 100.00% <ø> (ø)
python/cugraph/comms/comms.py 34.52% <25.00%> (ø)
python/cugraph/dask/common/input_utils.py 23.07% <28.57%> (+1.14%) ⬆️
python/cugraph/utilities/utils.py 42.96% <35.71%> (-28.59%) ⬇️
python/cugraph/dask/common/mg_utils.py 37.50% <38.09%> (-2.50%) ⬇️
python/cugraph/community/spectral_clustering.py 72.54% <38.46%> (-11.67%) ⬇️
python/cugraph/structure/number_map.py 58.12% <50.00%> (+2.16%) ⬆️
python/cugraph/structure/graph.py 68.75% <76.47%> (+1.95%) ⬆️
python/cugraph/__init__.py 100.00% <100.00%> (ø)
...ython/cugraph/centrality/betweenness_centrality.py 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f35bcb...fa4b3f3. Read the comment docs.

@BradReesWork BradReesWork added this to the 0.18 milestone Jan 25, 2021
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 25, 2021
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Show resolved Hide resolved
@jolorunyomi jolorunyomi requested review from a team as code owners January 26, 2021 17:54
@jolorunyomi jolorunyomi changed the title update pr-labeler configuration Auto-label PRs based on their content [skip-ci] Jan 29, 2021
@mike-wendt
Copy link
Contributor

mike-wendt commented Jan 29, 2021

@jolorunyomi can you rebase? this shouldn't include any other changes besides the two config files - reviews for the config files can proceed

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably fine as-is, but as mentioned in a comment, having the cmake label would be nice.

Also, our recently-updated .github/CODEOWNERS has many more extensions for docs than what's listed here. I don't know if we want docs limited to .md files for labels, but if not then I'd refer to the CODEOWNERS file to see a more exhaustive list.

Let me know what you want to do and I'll re-review, or if you don't feel those changes are appropriate I'll approve this.

@mike-wendt
Copy link
Contributor

I think this is probably fine as-is, but as mentioned in a comment, having the cmake label would be nice.

Also, our recently-updated .github/CODEOWNERS has many more extensions for docs than what's listed here. I don't know if we want docs limited to .md files for labels, but if not then I'd refer to the CODEOWNERS file to see a more exhaustive list.

Let me know what you want to do and I'll re-review, or if you don't feel those changes are appropriate I'll approve this.

@jolorunyomi can you take a look at the updated CODEOWNERS and port over the new docs paths?

@mike-wendt
Copy link
Contributor

mike-wendt commented Feb 1, 2021

@rlratzel are these the paths you would like for the doc label?

From https://github.com/rapidsai/cugraph/blob/branch-0.18/.github/CODEOWNERS#L4-L13

datasets/          @rapidsai/cugraph-doc-codeowners
notebooks/         @rapidsai/cugraph-doc-codeowners
docs/              @rapidsai/cugraph-doc-codeowners
**/*.txt           @rapidsai/cugraph-doc-codeowners
**/*.md            @rapidsai/cugraph-doc-codeowners
**/*.rst           @rapidsai/cugraph-doc-codeowners
**/*.ipynb         @rapidsai/cugraph-doc-codeowners
**/*.pdf           @rapidsai/cugraph-doc-codeowners
**/*.png           @rapidsai/cugraph-doc-codeowners

@rlratzel
Copy link
Contributor

rlratzel commented Feb 1, 2021

@rlratzel are these the paths you would like for the doc label?

From https://github.com/rapidsai/cugraph/blob/branch-0.18/.github/CODEOWNERS#L4-L13

datasets/          @rapidsai/cugraph-doc-codeowners
notebooks/         @rapidsai/cugraph-doc-codeowners
docs/              @rapidsai/cugraph-doc-codeowners
**/*.txt           @rapidsai/cugraph-doc-codeowners
**/*.md            @rapidsai/cugraph-doc-codeowners
**/*.rst           @rapidsai/cugraph-doc-codeowners
**/*.ipynb         @rapidsai/cugraph-doc-codeowners
**/*.pdf           @rapidsai/cugraph-doc-codeowners
**/*.png           @rapidsai/cugraph-doc-codeowners

Yes that looks good, thanks.

@mike-wendt
Copy link
Contributor

@rlratzel are these the paths you would like for the doc label?
From https://github.com/rapidsai/cugraph/blob/branch-0.18/.github/CODEOWNERS#L4-L13

datasets/          @rapidsai/cugraph-doc-codeowners
notebooks/         @rapidsai/cugraph-doc-codeowners
docs/              @rapidsai/cugraph-doc-codeowners
**/*.txt           @rapidsai/cugraph-doc-codeowners
**/*.md            @rapidsai/cugraph-doc-codeowners
**/*.rst           @rapidsai/cugraph-doc-codeowners
**/*.ipynb         @rapidsai/cugraph-doc-codeowners
**/*.pdf           @rapidsai/cugraph-doc-codeowners
**/*.png           @rapidsai/cugraph-doc-codeowners

Yes that looks good, thanks.

@jolorunyomi can you make these changes to the config file for the doc label?

@mike-wendt mike-wendt removed the request for review from a team February 1, 2021 21:50
@mike-wendt
Copy link
Contributor

Dropped python-codeowners from review as they were added before the rebase and this PR contains no python code

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 683797d into branch-0.18 Feb 2, 2021
@mike-wendt mike-wendt deleted the cugraph-pr-labeler branch February 4, 2021 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants