Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GIT_SHALLOW from CMakeLists.txt [skip-ci-changelog] #1261

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

ajschmidt8
Copy link
Member

This PR removes GIT_SHALLOW (which is not compatible with commit hashes) from the cuco fetch function to prevent build errors from occurring. This is similar to Rick's fix in #1250, but now needs to be backported to 0.16 since Ops needs to re-release 0.16 and this issue is causing build errors.

This fix was confirmed locally.

As outlined in the CMake docs:

If GIT_SHALLOW is enabled then GIT_TAG works only with branch names and tags. A commit hash is not allowed.

@ajschmidt8 ajschmidt8 added the bug Something isn't working label Nov 6, 2020
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner November 6, 2020 17:57
@ajschmidt8 ajschmidt8 changed the base branch from branch-0.16 to main November 6, 2020 18:18
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@mike-wendt mike-wendt changed the title Remove GIT_SHALLOW from CMakeLists.txt Remove GIT_SHALLOW from CMakeLists.txt [skip-ci-changelog] Nov 6, 2020
@mike-wendt
Copy link
Contributor

rerun tests

@codecov-io
Copy link

Codecov Report

Merging #1261 (11c75af) into main (892a8e1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1261   +/-   ##
=======================================
  Coverage   56.59%   56.59%           
=======================================
  Files          62       62           
  Lines        2564     2564           
=======================================
  Hits         1451     1451           
  Misses       1113     1113           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 892a8e1...11c75af. Read the comment docs.

@ajschmidt8 ajschmidt8 merged commit 8e9f68d into main Nov 6, 2020
@ajschmidt8 ajschmidt8 deleted the update-cuco-fetch branch November 6, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants