Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] BUG fix benchmark notebooks for recent cudf changes #1192

Merged
merged 13 commits into from
Oct 7, 2020
Merged

[REVIEW] BUG fix benchmark notebooks for recent cudf changes #1192

merged 13 commits into from
Oct 7, 2020

Conversation

BradReesWork
Copy link
Member

Fixed benchmark notebooks

Fix docs in graph.py

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@BradReesWork BradReesWork changed the title BUG fix notebooks for recent cudf changes [WIP] BUG fix notebooks for recent cudf changes Oct 6, 2020
@BradReesWork BradReesWork added this to the 0.16 milestone Oct 6, 2020
@BradReesWork BradReesWork changed the title [WIP] BUG fix notebooks for recent cudf changes [REVIEW] BUG fix benchmark notebooks for recent cudf changes Oct 6, 2020
@BradReesWork BradReesWork requested a review from a team as a code owner October 6, 2020 17:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2020

Codecov Report

Merging #1192 into branch-0.16 will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.16    #1192      +/-   ##
===============================================
- Coverage        57.41%   57.39%   -0.03%     
===============================================
  Files               61       61              
  Lines             2482     2483       +1     
===============================================
  Hits              1425     1425              
- Misses            1057     1058       +1     
Impacted Files Coverage Δ
python/cugraph/dask/community/louvain.py 31.81% <0.00%> (-1.52%) ⬇️
python/cugraph/structure/graph.py 64.51% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b1bb3...365a312. Read the comment docs.

Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just small things like hardcoded "last edit date" are outdated.

@BradReesWork BradReesWork requested review from wangxiaoyunNV and removed request for wangxiaoyunNV October 6, 2020 19:20
@codecov-io
Copy link

codecov-io commented Oct 6, 2020

Codecov Report

❗ No coverage uploaded for pull request base (branch-0.16@a4b1bb3). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             branch-0.16    #1192   +/-   ##
==============================================
  Coverage               ?   57.39%           
==============================================
  Files                  ?       61           
  Lines                  ?     2483           
  Branches               ?        0           
==============================================
  Hits                   ?     1425           
  Misses                 ?     1058           
  Partials               ?        0           
Impacted Files Coverage Δ
python/cugraph/dask/community/louvain.py 31.81% <0.00%> (ø)
python/cugraph/structure/graph.py 64.51% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b1bb3...6feacca. Read the comment docs.

@BradReesWork BradReesWork merged commit ae5d0f2 into rapidsai:branch-0.16 Oct 7, 2020
@BradReesWork BradReesWork deleted the branch-0.16-docs branch February 10, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants