-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW][skip-ci] new notebook for benchmarking #1093
[REVIEW][skip-ci] new notebook for benchmarking #1093
Conversation
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only saw one typo and a few blank cells that I'm assuming you don't want, and the rest of the comments are more stylistic suggestions and some questions.
"def nx_bfs(_df):\n", | ||
" t1 = time.time()\n", | ||
" _G = create_nx_ugraph(_df)\n", | ||
" _ = nx.bfs_edges(_G, 1)\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Nx actually run BFS or returns a lazy generator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does return a lazy generator. Really need to step through all the levels to get a full sense of the runtime. But there is so much extra overhead that I would also need to have cuGraph run through all the levels as well. Right now it is just going to be a note on the slide
"except ModuleNotFoundError:\n", | ||
" os.system('pip install matplotlib')\n", | ||
"\n", | ||
"import matplotlib.pyplot as plt; plt.rcdefaults()\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't find where matplotlib is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to generator a plot at the bottom like in the other notebooks. That it a pending update
No description provided.