Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW][skip-ci] new notebook for benchmarking #1093

Merged
merged 8 commits into from
Aug 20, 2020
Merged

[REVIEW][skip-ci] new notebook for benchmarking #1093

merged 8 commits into from
Aug 20, 2020

Conversation

BradReesWork
Copy link
Member

No description provided.

@BradReesWork BradReesWork added this to the 0.15 milestone Aug 18, 2020
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@BradReesWork BradReesWork changed the title [WIP][skip-ci] new notebook for benchmarking [REVIEW][skip-ci] new notebook for benchmarking Aug 20, 2020
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only saw one typo and a few blank cells that I'm assuming you don't want, and the rest of the comments are more stylistic suggestions and some questions.

notebooks/cugraph_benchmarks/release.ipynb Outdated Show resolved Hide resolved
notebooks/cugraph_benchmarks/release.ipynb Outdated Show resolved Hide resolved
notebooks/cugraph_benchmarks/release.ipynb Show resolved Hide resolved
notebooks/cugraph_benchmarks/release.ipynb Show resolved Hide resolved
notebooks/cugraph_benchmarks/release.ipynb Outdated Show resolved Hide resolved
notebooks/cugraph_benchmarks/release.ipynb Outdated Show resolved Hide resolved
notebooks/cugraph_benchmarks/release.ipynb Show resolved Hide resolved
notebooks/cugraph_benchmarks/release.ipynb Show resolved Hide resolved
notebooks/cugraph_benchmarks/release.ipynb Outdated Show resolved Hide resolved
notebooks/cugraph_benchmarks/release.ipynb Outdated Show resolved Hide resolved
notebooks/cugraph_benchmarks/release.ipynb Outdated Show resolved Hide resolved
"def nx_bfs(_df):\n",
" t1 = time.time()\n",
" _G = create_nx_ugraph(_df)\n",
" _ = nx.bfs_edges(_G, 1)\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Nx actually run BFS or returns a lazy generator?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does return a lazy generator. Really need to step through all the levels to get a full sense of the runtime. But there is so much extra overhead that I would also need to have cuGraph run through all the levels as well. Right now it is just going to be a note on the slide

"except ModuleNotFoundError:\n",
" os.system('pip install matplotlib')\n",
"\n",
"import matplotlib.pyplot as plt; plt.rcdefaults()\n"
Copy link
Member

@afender afender Aug 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't find where matplotlib is used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to generator a plot at the bottom like in the other notebooks. That it a pending update

@BradReesWork BradReesWork merged commit 68fde60 into rapidsai:branch-0.15 Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants