Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] MG BFS Dask PR #1010

Merged
merged 16 commits into from
Jul 29, 2020
Merged

[REVIEW] MG BFS Dask PR #1010

merged 16 commits into from
Jul 29, 2020

Conversation

kaatish
Copy link
Collaborator

@kaatish kaatish commented Jul 17, 2020

No description provided.

@kaatish kaatish requested a review from a team as a code owner July 17, 2020 17:13
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

1 similar comment
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@afender afender changed the title [WIP] OPG BFS Dask PR [WIP] MG BFS Dask PR Jul 17, 2020
@kaatish kaatish requested a review from a team as a code owner July 21, 2020 14:22
@BradReesWork BradReesWork added this to the 0.15 milestone Jul 28, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020 •
edited
Loading

Codecov Report

Merging #1010 into branch-0.15 will increase coverage by 0.41%.
The diff coverage is 88.63%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.15    #1010      +/-   ##
===============================================
+ Coverage        67.89%   68.31%   +0.41%     
===============================================
  Files               57       57              
  Lines             2031     2061      +30     
===============================================
+ Hits              1379     1408      +29     
- Misses             652      653       +1
Impacted Files Coverage Δ
python/cugraph/dask/mg_pagerank/pagerank.py 96.00% <ø> (ø)
python/cugraph/comms/comms.py 83.33% <75.00%> (ø)
python/cugraph/dask/common/input_utils.py 96.90% <75.00%> (ø)
python/cugraph/structure/graph.py 75.64% <80.00%> (-0.79%) ⬇️
python/cugraph/dask/mg_bfs/bfs.py 96.00% <96.00%> (ø)
python/cugraph/dask/__init__.py 100.00% <100.00%> (ø)
python/cugraph/mg/traversal/__init__.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f94a6...39425ce. Read the comment docs.

@afender afender changed the title [WIP] MG BFS Dask PR [REVIEW] MG BFS Dask PR Jul 29, 2020
afender
afender reviewed Jul 29, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
python/cugraph/dask/mg_bfs/bfs.py Outdated Show resolved Hide resolved
python/cugraph/dask/mg_bfs/bfs.py Outdated Show resolved Hide resolved
python/cugraph/dask/mg_bfs/bfs.py Outdated Show resolved Hide resolved
python/cugraph/tests/dask/test_mg_bfs.py Outdated Show resolved Hide resolved
python/cugraph/mg/traversal/mg_bfs_wrapper.pyx Show resolved Hide resolved
python/cugraph/mg/traversal/mg_bfs_wrapper.pyx Show resolved Hide resolved
python/cugraph/dask/mg_bfs/bfs.py Show resolved Hide resolved
python/cugraph/tests/dask/test_mg_bfs.py Outdated Show resolved Hide resolved
Iroy30
Iroy30 approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@Iroy30 Iroy30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👌. Waiting for tests to pass

@afender afender merged commit 0acc62d into rapidsai:branch-0.15 Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afender afender afender approved these changes

@Iroy30 Iroy30 Iroy30 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.
6 participants
@kaatish @GPUtester @codecov-commenter @Iroy30 @afender @BradReesWork