Remove deprecated support for legacy uniform_neighbor_sampling args in 23.10 #3698
Assignees
Labels
Comments
alexbarghi-nv
added
improvement
rapids-bot bot
pushed a commit
that referenced
this issue
Sep 1, 2023
The `uniform_neighbor_sample` code is becoming increasingly difficult to maintain. This PR removes all the options that were deprecated in the previous release, and also deprecates the `with_edge_properties` option, which will be replaced by returning whatever properties are in the graph in the next release. This PR also resolves a FIXME by allowing `fanout_vals` to be a `cupy.ndarray`, `numpy.ndarray`, or `cudf.Series`. Closes #3698 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) Approvers: - Brad Rees (https://github.com/BradReesWork) - Rick Ratzel (https://github.com/rlratzel) URL: #3816
rlratzel
pushed a commit
to rlratzel/cugraph
that referenced
this issue
Sep 8, 2023
The `uniform_neighbor_sample` code is becoming increasingly difficult to maintain. This PR removes all the options that were deprecated in the previous release, and also deprecates the `with_edge_properties` option, which will be replaced by returning whatever properties are in the graph in the next release. This PR also resolves a FIXME by allowing `fanout_vals` to be a `cupy.ndarray`, `numpy.ndarray`, or `cudf.Series`. Closes rapidsai#3698 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) Approvers: - Brad Rees (https://github.com/BradReesWork) - Rick Ratzel (https://github.com/rlratzel) URL: rapidsai#3816
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Added in #3669
This issue is a reminder to remove the legacy support code in the 23.10 release
The text was updated successfully, but these errors were encountered: