Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Update python benchmarks to ensure a pylibcugraph.MG/SGGraph is created prior to running benchmarked algos #2375

Closed
rlratzel opened this issue Jun 24, 2022 · 1 comment · Fixed by #2682
Closed

[FEA] Update python benchmarks to ensure a pylibcugraph.MG/SGGraph is created prior to running benchmarked algos #2375

rlratzel opened this issue Jun 24, 2022 · 1 comment · Fixed by #2682
Assignees
@jnke2016 @alexbarghi-nv
Milestone
22.10

Comments

@rlratzel
Copy link
Contributor

Once #2374 is complete, our benchmarks should be updated to ensure Graph objects have created a pylibcugraph.MG/SGGraph, with the correct transpose orientation, prior to calling the algo to be benchmarked.

For Developers below this line

  • [] Code passes CI
  • [] Code uses Graph Primitives
  • [] Code in C++/CUDA layer
  • [] Code in C layer
  • [] Code in pylibcugraph Python layer
  • [] Code in cugraph Python layer
  • [] Documentation
  • [] Test cases at each layer (for MG tests, a note in the PR description indicating the new/existing MG tests were run and passed)
@rlratzel rlratzel added the ? - Needs Triage Need team to review and classify label Jun 24, 2022
@rlratzel rlratzel added this to the 22.08 milestone Jul 5, 2022
@rlratzel rlratzel modified the milestones: 22.08, 22.10 Aug 3, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@jnke2016 jnke2016 mentioned this issue Sep 11, 2022
Merged
rapids-bot bot pushed a commit that referenced this issue Sep 27, 2022
@jnke2016
Enable PLC algos to leverage the PLC graph (#2682)
7af4229 
This PR enables the PLC `algos` to leverage the `PLC `graph created prior to running the `algos`. This will enable the exclusion of the graph creation time from the algo's run time for more accurate benchmarks. This PR also updates the tests accordingly (by skipping the `cython.cu `renumbering) along with the docstrings.

closes #2375
closes #2374

Authors:
  - Joseph Nke (https://github.com/jnke2016)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)

URL: #2682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnke2016 jnke2016

@alexbarghi-nv alexbarghi-nv

Labels
None yet
Projects
None yet
Milestone
22.10
Development

Successfully merging a pull request may close this issue.

Enable PLC algos to leverage the PLC graph jnke2016/cugraph
3 participants
@rlratzel @jnke2016 @alexbarghi-nv