Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate MG library from SG library #1770

Closed
1 task
ChuckHastings opened this issue Aug 12, 2021 · 1 comment
Closed
1 task

Separate MG library from SG library #1770

ChuckHastings opened this issue Aug 12, 2021 · 1 comment
Assignees
@ChuckHastings
Labels
? - Needs Triage Need team to review and classify Epic Tracker for a relatively large body of work that is broken down into stories and issues

Comments

@ChuckHastings
Copy link
Collaborator

ChuckHastings commented Aug 12, 2021 •
edited by BradReesWork
Loading

We have several issues regarding MG development:

  • As more analytics are converted to use the primitives and support MG, the size of our shared object library is getting larger
  • Support the MG analytics (in C++) requires some additional library dependencies that get propagated, even to users that just want to use SG

We expect there will continue to be many users that will want to use SG cugraph analytics and won't need the MG capabilities.

To that end, this issue intends to separate the MG library into a separate shared object library. This will allow SG users to use just the SG library and its dependencies. An MG user will also build/download the MG library (along with its dependencies).

This effort will need to be followed up by one or more packaging efforts (e.g. making separate Conda packages) to truly expose this to the user.

Tasks
Beta Give feedback
@ChuckHastings ChuckHastings added the ? - Needs Triage Need team to review and classify label Aug 12, 2021
@ChuckHastings ChuckHastings self-assigned this Aug 12, 2021
@ChuckHastings ChuckHastings added 2 - In Progress feature request New feature or request and removed ? - Needs Triage Need team to review and classify labels Aug 12, 2021
@ChuckHastings ChuckHastings added this to the 21.10 milestone Aug 12, 2021
@ChuckHastings ChuckHastings mentioned this issue Aug 12, 2021
Closed
@ChuckHastings ChuckHastings mentioned this issue Sep 2, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Sep 8, 2021
@ChuckHastings
Split many files to separate SG from MG template instantiations (#1803)
c3d798f 
Partially addresses #1770

This is preliminary work to separate the SG and MG shared object libraries. This PR splits many of the source files that instantiate SG and MG variants of algorithms/objects/functions.

There will be subsequent PRs that will refactor the CMake structure and probably move some more files around.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: #1803
@BradReesWork BradReesWork modified the milestones: 21.10, 21.12 Sep 29, 2021
@ChuckHastings ChuckHastings modified the milestones: 21.12, 22.02 Nov 15, 2021
@ChuckHastings ChuckHastings added the Epic Tracker for a relatively large body of work that is broken down into stories and issues label Nov 15, 2021
@ChuckHastings ChuckHastings changed the title [ENH] Separate MG library from SG library [EPIC] Separate MG library from SG library Nov 15, 2021
@BradReesWork BradReesWork removed this from the 22.02 milestone Jan 26, 2022
@kingmesal kingmesal changed the title [EPIC] Separate MG library from SG library Separate MG library from SG library Feb 14, 2023
@BradReesWork BradReesWork added the ? - Needs Triage Need team to review and classify label Jul 6, 2023
@kingmesal kingmesal closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2023
@rapidsai rapidsai deleted a comment from github-actions bot Aug 1, 2023
@rapidsai rapidsai deleted a comment from github-actions bot Aug 1, 2023
@rapidsai rapidsai deleted a comment from github-actions bot Aug 1, 2023
@rapidsai rapidsai deleted a comment from github-actions bot Aug 1, 2023
@rlratzel
Copy link
Contributor

rlratzel commented Aug 1, 2023

closing due to no longer needing this feature. PLC handles most of the reasons we would need a non-MG package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChuckHastings ChuckHastings

Labels
? - Needs Triage Need team to review and classify Epic Tracker for a relatively large body of work that is broken down into stories and issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rlratzel @kingmesal @BradReesWork @ChuckHastings @jarmak-nv