Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] libcugraph should have version information made available to clients #1472

Closed
rlratzel opened this issue Mar 18, 2021 · 1 comment · Fixed by #1476
Closed

[ENH] libcugraph should have version information made available to clients #1472

rlratzel opened this issue Mar 18, 2021 · 1 comment · Fixed by #1476
Assignees
@rlratzel
Labels
? - Needs Triage Need team to review and classify

Comments

@rlratzel
Copy link
Contributor

rlratzel commented Mar 18, 2021 •
edited
Loading

Similar to RMM's version_config.hpp:

rmm/version_config.hpp:#define RMM_VERSION_MAJOR 0
rmm/version_config.hpp:#define RMM_VERSION_MINOR 18
rmm/version_config.hpp:#define RMM_VERSION_PATCH 0

(generated at build time using this mechanism), libcugraph should also include preprocessor defines that clients can use to check for compatibility. libcugraph should copy this mechanism for consistency with RMM and any other RAPIDS libs that use it.
@rlratzel rlratzel added the ? - Needs Triage Need team to review and classify label Mar 18, 2021
@rlratzel rlratzel self-assigned this Mar 18, 2021
@rlratzel
Copy link
Contributor Author

rlratzel commented Mar 18, 2021 •
edited
Loading

FYI: @anaruse

@jrhemstad , @harrism , @kkraus14 - is this the current recommendation, or is there a more preferred way of giving C++ clients version info?

@rlratzel rlratzel mentioned this issue Mar 22, 2021
Merged
rapids-bot bot pushed a commit that referenced this issue Mar 22, 2021
@rlratzel
Added cmake function and .hpp template for generating version_config.…
254a999 
…hpp file. (#1476)

Adds cmake function and .hpp template for generating a `version_config.hpp` file, similar to RMM's file of the same name.  This allows C++ clients to include the file from the libcugraph install to query version information for reporting, checking compatibility, etc.

Tested by building and installing libcugraph and checking that `version_config.hpp` was present in the conda environment and contained the correct information.

closes #1472 

FYI @anaruse

Authors:
  - Rick Ratzel (@rlratzel)

Approvers:
  - Brad Rees (@BradReesWork)
  - Alex Fender (@afender)

URL: #1476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlratzel rlratzel

Labels
? - Needs Triage Need team to review and classify
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added cmake function and .hpp template for generating version_config.hpp file. rlratzel/cugraph
1 participant
@rlratzel