Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for cuGraph-GNN #53

Closed
wants to merge 59 commits into from

Conversation

@alexbarghi-nv alexbarghi-nv added non-breaking Introduces a non-breaking change feature request New feature or request labels Oct 11, 2024
@@ -3,9 +3,11 @@
[build-system]

requires = [
"rapids-build-backend>=0.3.1,<0.4.0.dev0",
Copy link
Member

@jameslamb jameslamb Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting a threaded conversation so this can be collapsed once it's resolved.

I just pushed some commits that will hopefully allow CI to get further.

cugraph-dgl and cugraph-pyg on this branch were very far behind the cugraph repo. For example, I found that many of the changes from rapidsai/cugraph#4393 (merged into cugraph 3+ months ago) had not made it here.

I just copied over the packaging changes because I don't understand the current state of the cugraph-gnn repo. There have, for example, been code changes to the libraries themselves here (like #46).

Just calling it out for you @alexbarghi-nv in case I've misunderstood and those packaging changes being missed actually means something else went wrong resolving a merge conflict or something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been keeping the code up to date with cugraph. All the PRs I merged for cuGraph-DGL/PyG, and all the PRs for WholeGraph in 24.10 were replicated here. But the WG team said they are not going to merge any 24.12 PRs until we have CI working, and I am respecting their decision.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very possible I missed some PRs that updated CI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's helpful context, thank you.

rapids-bot bot pushed a commit that referenced this pull request Oct 16, 2024
Proposing breaking some changes off of #53, to reduce the size of that PR and get some CI running on PRs in this repo.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #56
rapids-bot bot pushed a commit that referenced this pull request Oct 21, 2024
This PR introduces full end-to-end CI for wholegraph.

## Notes for Reviewers

Most of these changes were pulled from a mix of the following:

* #53
* rapidsai/wholegraph#230
* https://github.com/rapidsai/wholegraph

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #58
rapids-bot bot pushed a commit that referenced this pull request Oct 30, 2024
Another steps towards completing the work started in #53 

Fixes #15

Contributes to rapidsai/build-planning#111

Proposes changes to get CI running on pull requests for `cugraph-pyg` and `cugraph-dgl`

## Notes for Reviewers

Workflows for nightly builds and publishing nightly packages are intentionally not included here. See #58 (comment)

Notebook tests are intentionally not added here... they'll be added in the next PR.

Pulls in changes from these other upstream PRs that had not been ported over to this repo:

* rapidsai/cugraph#4690
* rapidsai/cugraph#4393

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Alex Barghi (https://github.com/alexbarghi-nv)

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - Bradley Dice (https://github.com/bdice)

URL: #59
rapids-bot bot pushed a commit that referenced this pull request Oct 31, 2024
Continues the work of setting up CI here (breaking more changes off of #53).

Proposes adding nightly builds / tests, but **not publishing** to the nightly PyPI index / `rapidsai-nightly` conda channel. Those publishing jobs should be added here only once `cugraph` folks are ready to fully move development of these libraries to this repo. ref: #58 (comment)

This also removes some minor lingering cugraph references that look like they don't belong in this repo.

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Bradley Dice (https://github.com/bdice)

URL: #61
@rapids-bot rapids-bot bot closed this in #62 Nov 8, 2024
@rapids-bot rapids-bot bot closed this in d260ccb Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants