Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CUDA stream use in cuIO #9991

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Jan 7, 2022

Removes defaults for internal stream parameters.
Fixes cases where default stream was used instead of propagating the stream.

@vuule vuule added cuIO cuIO issue improvement Improvement / enhancement to an existing function labels Jan 7, 2022
@vuule vuule self-assigned this Jan 7, 2022
@vuule vuule added the non-breaking Non-breaking change label Jan 7, 2022
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #9991 (a03285a) into branch-22.02 (967a333) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9991      +/-   ##
================================================
- Coverage         10.49%   10.45%   -0.04%     
================================================
  Files               119      119              
  Lines             20305    20417     +112     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18283     +108     
Impacted Files Coverage Δ
python/custreamz/custreamz/kafka.py 29.16% <0.00%> (-0.63%) ⬇️
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d69ea61...a03285a. Read the comment docs.

@vuule
Copy link
Contributor Author

vuule commented Jan 7, 2022

rerun tests

@vuule vuule marked this pull request as ready for review January 7, 2022 18:58
@vuule vuule requested a review from a team as a code owner January 7, 2022 18:58
@davidwendt
Copy link
Contributor

This looks good to me. Just update the copyright year I think.

@vuule
Copy link
Contributor Author

vuule commented Jan 7, 2022

This looks good to me. Just update the copyright year I think.

Lol, I just checked the year in some files and did not update since "2021 is already included".

@vuule vuule added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jan 7, 2022
@vuule
Copy link
Contributor Author

vuule commented Jan 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 42a0e55 into rapidsai:branch-22.02 Jan 7, 2022
@vuule vuule deleted the bug-default-stream-param branch January 7, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants