-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix groupby shift/diff/fill after selecting from a GroupBy
#9984
Fix groupby shift/diff/fill after selecting from a GroupBy
#9984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thnx!
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9984 +/- ##
================================================
- Coverage 10.49% 10.45% -0.04%
================================================
Files 119 119
Lines 20305 20414 +109
================================================
+ Hits 2130 2134 +4
- Misses 18175 18280 +105
Continue to review full report at Codecov.
|
@gpucibot merge |
Fixes #9969
Due to a bug in
GroupBy.__getitem__
, selecting a column of aGroupBy
and then doing a shift, diff, or fill operation would result in the operation being performed on the wrong values. This PR fixesGroupBy.__getitem__
so we now have the right behaviour.