Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jni for sequences #9972

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Conversation

wbo4958
Copy link
Contributor

@wbo4958 wbo4958 commented Jan 5, 2022

This PR add java binding for sequences API. and to fix #9424.

@wbo4958 wbo4958 requested a review from a team as a code owner January 5, 2022 02:51
@github-actions github-actions bot added the Java Affects Java cuDF API. label Jan 5, 2022
@wbo4958 wbo4958 added feature request New feature or request non-breaking Non-breaking change labels Jan 5, 2022
@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #9972 (b805c7b) into branch-22.02 (967a333) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head b805c7b differs from pull request most recent head a1714be. Consider uploading reports for the commit a1714be to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9972      +/-   ##
================================================
- Coverage         10.49%   10.41%   -0.08%     
================================================
  Files               119      119              
  Lines             20305    20480     +175     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18346     +171     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ae789...a1714be. Read the comment docs.

@@ -23,6 +23,7 @@
#include <cudf/interop.hpp>
Copy link
Contributor

@firestarman firestarman Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However forgot to update the copyright year in this file.

- Copyright (c) 2019-2021, NVIDIA CORPORATION.
+ Copyright (c) 2019-2022, NVIDIA CORPORATION.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, Done.

@revans2
Copy link
Contributor

revans2 commented Jan 5, 2022

The failing java premerge is known issue.

@revans2
Copy link
Contributor

revans2 commented Jan 5, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6a6fbb3 into rapidsai:branch-22.02 Jan 5, 2022
@wbo4958 wbo4958 deleted the sequences-jni branch January 5, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Add API for generating per-list sequences
4 participants