-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove various unused functions #9922
Remove various unused functions #9922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm reviewing this to help resolve #9824. I see a few inconsistencies with imports, otherwise LGTM.
This reverts commit 7f73497.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@vyasr CI is failing for dask-cudf because the removed function
|
I saw, just hadn't gotten around to fixing it yet. Will address it later today. Those specific calls aren't the issue, because they're calls to methods of the dask DataFrame objects and |
rerun tests |
I merged in |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9922 +/- ##
================================================
+ Coverage 10.37% 10.41% +0.04%
================================================
Files 119 119
Lines 20111 20481 +370
================================================
+ Hits 2086 2134 +48
- Misses 18025 18347 +322
Continue to review full report at Codecov.
|
@gpucibot merge |
This PR removes a number of unused functions and inlines some helpers that are only called in one place. This PR also deprecates
Series.fill
, which does not appear to be a pandas API. This PR resolves #9824.