Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IncludeCategories from .clang-format #9876

Merged
merged 12 commits into from
Dec 12, 2021
Merged

Remove IncludeCategories from .clang-format #9876

merged 12 commits into from
Dec 12, 2021

Conversation

codereport
Copy link
Contributor

@codereport codereport commented Dec 9, 2021 •
edited
Loading

It was recently noticed that the IncludeCategories:

IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3

In the .clang-format are not really necessary as ext has no meaning in RAPIDS. This PR removes these.

Depends on #9870.

@codereport codereport added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 9, 2021
@codereport codereport self-assigned this Dec 9, 2021
@codereport codereport requested a review from a team as a code owner December 9, 2021 15:42
@codereport
Copy link
Contributor Author

Note CI is failing because of #9870 not because of the clang-format changes

This was referenced Dec 9, 2021
Merged
Merged
bdice
bdice approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-format changes look good. Part of me wants to fix the #include "..."s that should be using <...> revealed in this changeset, but that's not a blocker since the changes were automated and this PR touches a lot of files that would be time consuming to fix.

@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond labels Dec 9, 2021
This was referenced Dec 9, 2021
Merged
Merged
mythrocks
mythrocks approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this change, save for keeping the #include "header.hpp" style of includes.
Please ignore if that's not the focus of changes here. I've flagged them as suggestions where I could, for easy correction.

@codereport
Copy link
Contributor Author

+1 for this change, save for keeping the #include "header.hpp" style of includes. Please ignore if that's not the focus of changes here. I've flagged them as suggestions where I could, for easy correction.

It's all good. I committed them all, pulled down and reran clang-format. Thanks 👍

@codereport
Copy link
Contributor Author

rerun tests

@codereport
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Dec 9, 2021 •
edited
Loading

Codecov Report

Merging #9876 (e75e725) into branch-22.02 (967a333) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9876      +/-   ##
================================================
- Coverage         10.49%   10.42%   -0.07%     
================================================
  Files               119      119              
  Lines             20305    20479     +174     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18345     +170
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e581734...e75e725. Read the comment docs.

@codereport
Copy link
Contributor Author

rerun tests

@bdice bdice mentioned this pull request Dec 10, 2021
Merged
@codereport
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d23bcb4 into rapidsai:branch-22.02 Dec 12, 2021
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this pull request Dec 14, 2021
@codereport
Remove IncludeCategories from .clang-format (#470)
f0cede3 
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933
* `cuml`: rapidsai/cuml#4438
* `cugraph`: rapidsai/cugraph#1987

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #470
rapids-bot bot pushed a commit to rapidsai/raft that referenced this pull request Dec 16, 2021
@codereport
Remove IncludeCategories from .clang-format (#412)
d2e5b7a 
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933
* `cuml`: rapidsai/cuml#4438
* `cugraph`: rapidsai/cugraph#1987
* `cuspatial`: rapidsai/cuspatial#470

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #412
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Dec 17, 2021
@codereport
Remove IncludeCategories from .clang-format (#1987)
2a09714 
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933
* `cuml`: rapidsai/cuml#4438

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)

URL: #1987
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request Jan 8, 2022
@codereport
Remove IncludeCategories from .clang-format (#4438)
416ce61 
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Divye Gala (https://github.com/divyegala)

URL: #4438
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@codereport
Remove IncludeCategories from .clang-format (rapidsai#4438)
8c30dfe 
It was recently noticed that the `IncludeCategories`:
```
IncludeCategories:
  - Regex:           '^<ext/.*\.h>'
    Priority:        2
  - Regex:           '^<.*\.h>'
    Priority:        1
  - Regex:           '^<.*'
    Priority:        2
  - Regex:           '.*'
    Priority:        3
```
In the `.clang-format` are not really necessary as `ext` has no meaning in RAPIDS. This PR removes these.

Note these changes are being made in all repos:
* `cudf`: rapidsai/cudf#9876
* `rmm`: rapidsai/rmm#933

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - William Hicks (https://github.com/wphicks)
  - Divye Gala (https://github.com/divyegala)

URL: rapidsai#4438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythrocks mythrocks mythrocks approved these changes

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

Assignees

@codereport codereport

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codereport @bdice @mythrocks @ttnghia @rgsl888prabhu