Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cudf.Scalar string datetime construction #9875

Merged
merged 9 commits into from
Dec 15, 2021
Merged

Fix cudf.Scalar string datetime construction #9875

merged 9 commits into from
Dec 15, 2021

Conversation

brandon-b-miller
Copy link
Contributor

Closes #9874

@brandon-b-miller brandon-b-miller requested a review from a team as a code owner December 9, 2021 14:09
@github-actions github-actions bot added the Python Affects Python cuDF API. label Dec 9, 2021
@brandon-b-miller brandon-b-miller added bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API. 3 - Ready for Review Ready for review by team and removed Python Affects Python cuDF API. labels Dec 9, 2021
isVoid
isVoid approved these changes Dec 10, 2021
View reviewed changes
python/cudf/cudf/utils/dtypes.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 14, 2021

Codecov Report

Merging #9875 (a9331d6) into branch-22.02 (967a333) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9875      +/-   ##
================================================
- Coverage         10.49%   10.42%   -0.07%     
================================================
  Files               119      119              
  Lines             20305    20475     +170     
================================================
+ Hits               2130     2134       +4     
- Misses            18175    18341     +166
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.30% <0.00%> (-0.61%) ⬇️
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/series.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/dtypes.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 0.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23bcb4...a9331d6. Read the comment docs.

@brandon-b-miller
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 44fce8b into rapidsai:branch-22.02 Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid approved these changes

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu rgsl888prabhu is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Constructing a datetime cudf.Scalar from a string yields the wrong result in some cases
2 participants
@brandon-b-miller @isVoid