Fix ORC writer crash with empty input columns #9808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Python
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #9808 +/- ##
================================================
- Coverage 10.49% 10.47% -0.02%
================================================
Files 119 119
Lines 20305 20368 +63
================================================
+ Hits 2130 2133 +3
- Misses 18175 18235 +60
Continue to review full report at Codecov.
|
|
That's a lot of lines changed. Can you point me to the core of the changes which fix the issue? |
It's actually a small change, and all of it is relevant for the fix. The line count comes from added code blocks. Please try reviewing with "Hide whitespace" on. |
codereport
suggested changes
Dec 1, 2021
mythrocks
reviewed
Dec 1, 2021
galipremsagar
approved these changes
Dec 1, 2021
vyasr
approved these changes
Dec 1, 2021
Co-authored-by: Conor Hoekstra <[email protected]>
devavret
suggested changes
Dec 1, 2021
devavret
approved these changes
Dec 2, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 14, 2021
Follow up of #9808 Skips some kernels when input columns are empty to avoid OOB memory access. Authors: - Vukasin Milovanovic (https://github.com/vuule) Approvers: - Devavret Makkar (https://github.com/devavret) - Nghia Truong (https://github.com/ttnghia) - David Wendt (https://github.com/davidwendt) URL: #9896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9783
Skip some parts of writing when the input table was zero rows.
Add is_empty to
hostdevice_2dvector.Add Python test with empty columns.