Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Java native dependencies directly into classpath #9787

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Nov 29, 2021

Eliminates the intermediate copy of the native libraries for the Java bindings into target/native-deps, instead copying libcudf.so and libcudfjni.so directly into the classpath resources. This eliminates the need to search target/native-deps at runtime when the native libraries are not in the classpath in the case of running tests before the jar is built.

@jlowe jlowe added Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 29, 2021
@jlowe jlowe self-assigned this Nov 29, 2021
@jlowe jlowe requested a review from a team as a code owner November 29, 2021 17:56
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #9787 (fd43156) into branch-22.02 (967a333) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head fd43156 differs from pull request most recent head 0be1dab. Consider uploading reports for the commit 0be1dab to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9787      +/-   ##
================================================
- Coverage         10.49%   10.47%   -0.02%     
================================================
  Files               119      119              
  Lines             20305    20338      +33     
================================================
  Hits               2130     2130              
- Misses            18175    18208      +33     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83adc4b...0be1dab. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Nov 30, 2021

rerun tests

@jlowe
Copy link
Member Author

jlowe commented Nov 30, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 20d6723 into rapidsai:branch-22.02 Nov 30, 2021
@jlowe jlowe deleted the jni-reduce-lib-copies branch November 30, 2021 21:51
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants