Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Enable string to decimal 128 cast #9742

Merged
merged 1 commit into from
Nov 22, 2021
Merged

[Java] Enable string to decimal 128 cast #9742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions java/src/main/native/src/ColumnViewJni.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,6 +936,7 @@ JNIEXPORT jlong JNICALL Java_ai_rapids_cudf_ColumnView_castTo(JNIEnv *env, jclas
break;
case cudf::type_id::DECIMAL32:
case cudf::type_id::DECIMAL64:
case cudf::type_id::DECIMAL128:
result = cudf::strings::to_fixed_point(*column, n_data_type);
break;
default: JNI_THROW_NEW(env, "java/lang/IllegalArgumentException", "Invalid data type", 0);
Expand Down
16 changes: 16 additions & 0 deletions java/src/test/java/ai/rapids/cudf/ColumnVectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3370,6 +3370,22 @@ void testFixedWidthCast() {
}
}

@Test
void testCastStringToBigDecimal() {
String[] bigValues = {"923121331938210123.321",
"9223372036854775808.191",
"9328323982309091029831.002"
};

try (ColumnVector cv = ColumnVector.fromStrings(bigValues);
ColumnVector values = cv.castTo(DType.create(DType.DTypeEnum.DECIMAL128, -3));
ColumnVector expected = ColumnVector.fromDecimals(new BigDecimal("923121331938210123.321"),
new BigDecimal("9223372036854775808.191"),
new BigDecimal("9328323982309091029831.002"))) {
assertColumnsAreEqual(expected, values);
}
}

@Test
void testCastByteToString() {

Expand Down