Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support min and max in inclusive scan for structs #9725

Merged

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Nov 18, 2021

This PR continues to address #8974, adding support for structs in min and max inclusive scan. Exclusive scan support is not needed in the near future.

@ttnghia ttnghia added feature request New feature or request 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Nov 18, 2021
@ttnghia ttnghia self-assigned this Nov 18, 2021
@ttnghia ttnghia requested a review from a team as a code owner November 18, 2021 22:09
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #9725 (0633f25) into branch-22.02 (967a333) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 0633f25 differs from pull request most recent head e46a1cf. Consider uploading reports for the commit e46a1cf to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-22.02    #9725      +/-   ##
================================================
- Coverage         10.49%   10.47%   -0.02%     
================================================
  Files               119      119              
  Lines             20305    20341      +36     
================================================
  Hits               2130     2130              
- Misses            18175    18211      +36     
Impacted Files Coverage Δ
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/column.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <ø> (ø)
python/cudf/cudf/core/indexed_frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/multiindex.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/utils.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4629037...e46a1cf. Read the comment docs.

@ttnghia
Copy link
Contributor Author

ttnghia commented Nov 30, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0fa0cc4 into rapidsai:branch-22.02 Nov 30, 2021
@ttnghia ttnghia deleted the min_max_struct_inclusive_scan branch November 30, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants