Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in C++ Developer Guide. #9675

Merged
merged 4 commits into from
Nov 13, 2021
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Nov 12, 2021

This PR improves the C++ developer guide.

My primary goal was to fix some invalid links.

The diff is a bit large because of some minor changes in the interest of establishing consistent style and improving the reading/editing experience. (e.g. replacing a few instances of tabs with spaces, trimming trailing whitespace, wrapping sections that were not wrapped like the rest of the file, and correcting typos that I came across while reading). To save time, I recommend that reviewers use the option in GitHub's review tab that will ignore whitespace changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 12, 2021
@bdice bdice added the doc Documentation label Nov 12, 2021
@bdice bdice changed the base branch from branch-21.12 to branch-22.02 November 12, 2021 20:44
@bdice bdice self-assigned this Nov 12, 2021
@bdice bdice added the non-breaking Non-breaking change label Nov 12, 2021
@bdice bdice marked this pull request as ready for review November 12, 2021 20:46
@bdice bdice requested a review from a team as a code owner November 12, 2021 20:46
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bdice
Copy link
Contributor Author

bdice commented Nov 13, 2021

All the changes here are pretty minor, so I'm going to merge with one approval.

@bdice
Copy link
Contributor Author

bdice commented Nov 13, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d64e274 into rapidsai:branch-22.02 Nov 13, 2021
@bdice bdice deleted the fix-link branch November 15, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants