-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use _gather
internal for sort_*
#9668
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9668 +/- ##
================================================
- Coverage 10.79% 10.71% -0.08%
================================================
Files 116 117 +1
Lines 18869 19887 +1018
================================================
+ Hits 2036 2130 +94
- Misses 16833 17757 +924
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question I'm confused by before we push this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thought on whether DataFrame._gather should handle the columns logic, but otherwise good. I'll let you decide if there's anything to be done there (I think we can leave the code as is). Thanks!
This reverts commit 931a910.
@gpucibot merge |
closes #9667
This PR evades deprecation warning for
sort_*
apis. There's a corner case that the name of columns are multi level, and it's handled ad-hoc here. But should use more refactoring to the factory method.