Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _gather internal for sort_* #9668

Merged
merged 4 commits into from
Nov 12, 2021
Merged

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Nov 12, 2021

closes #9667

This PR evades deprecation warning for sort_* apis. There's a corner case that the name of columns are multi level, and it's handled ad-hoc here. But should use more refactoring to the factory method.

@isVoid isVoid requested a review from vyasr November 12, 2021 03:58
@isVoid isVoid requested a review from a team as a code owner November 12, 2021 03:58
@github-actions github-actions bot added the Python Affects Python cuDF API. label Nov 12, 2021
@isVoid isVoid added 3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #9668 (fb52838) into branch-21.12 (ab4bfaa) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9668      +/-   ##
================================================
- Coverage         10.79%   10.71%   -0.08%     
================================================
  Files               116      117       +1     
  Lines             18869    19887    +1018     
================================================
+ Hits               2036     2130      +94     
- Misses            16833    17757     +924     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5402787...fb52838. Read the comment docs.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question I'm confused by before we push this out.

python/cudf/cudf/core/indexed_frame.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/indexed_frame.py Show resolved Hide resolved
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thought on whether DataFrame._gather should handle the columns logic, but otherwise good. I'll let you decide if there's anything to be done there (I think we can leave the code as is). Thanks!

@vyasr
Copy link
Contributor

vyasr commented Nov 12, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 47af69a into rapidsai:branch-21.12 Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] sort_index/sort_values should call _gather API instead of take
2 participants