Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup to PR 9088 comments #9659

Merged
merged 38 commits into from
Nov 11, 2021
Merged

Followup to PR 9088 comments #9659

merged 38 commits into from
Nov 11, 2021

Conversation

cwharris
Copy link
Contributor

These are some minor updates requested for PR #9088 that I forgot to push prior to merging the PR.

@cwharris
simplify io/functions.cpp data source/sink factories
9c72e56
@cwharris
Merge branch 'branch-21.10' of github.com:rapidsai/cudf into io-funct…
884bde6 
…ions-simplify
@cwharris
remove filepath-related logic from csv and json readers
88e2399
@cwharris
remove filepath logic from avro, parquet, orc readers
62b9520
@cwharris
move range size padding calculation out of json/csv reader and in to …
fb01294 
…json/csv options
@cwharris
remove filepaths from json reader
d422aeb
@cwharris
replace json reader impl buffer member with local variable
e0cac1d
@cwharris
replace josn reader sources member with local variable
dc23634
@cwharris
delete useless json reader wrapper class
166c4d3
@cwharris
delete unused arrow namespace declaration
b3ce527
@cwharris
replace json reader_impl mr member with argument
5a997b8
@cwharris
replace json reader_impl options with local variable
89163fb
@cwharris
remove unused json_reader::allow_newlines_in_strings_ member
7ff3f1a
@cwharris
replace json reader_impl::opts_ with local variable
5c95398
@cwharris
remove json reader_impl byte_range members in place of local variables
0bde0b1
@cwharris
replace json reader_impl::dtypes_ with local variable
b4843f5
@cwharris
replace json reader_impl::metadata_ with local variable
f511e68
@cwharris
replace json reader_impl::data_ with local variable
5e307b5
@cwharris
replace json::reader_impl column_map members with local variables
f84dcc3
@cwharris
change json::reader_impl host buffer type from uint8_t to char
e11e9db
@cwharris
replace json::reader_impl uncomp data members with single span member
df10217
@cwharris
json::reader_impl simplify device data copy logic
0417be8
@cwharris
remove json::reader_impl::decompress_input function and inline the logic
f0fd5c1
@cwharris
replace json::reader_impl::uncomp_data_ member with local variable
45714bb
@cwharris
relocate json::reader_impl decompression code
8d18ffe
@cwharris
remove unneccessary json::reader_impl class
06a39b7
@cwharris
remove deprected file header format
c658af1
@cwharris
remove json_common.h
a1945af
@cwharris
Merge branch 'branch-21.10' of github.com:rapidsai/cudf into io-simpl…
e4b1621 
…ify-json
@cwharris
re-delete json reader_impl.hpp
cf5867f
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 11, 2021
@cwharris cwharris added 3 - Ready for Review Ready for review by team 4 - Needs cuIO Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Nov 11, 2021
@cwharris cwharris marked this pull request as ready for review November 11, 2021 16:14
@cwharris cwharris requested a review from a team as a code owner November 11, 2021 16:14
bdice
bdice requested changes Nov 11, 2021
View reviewed changes
cpp/include/cudf/io/detail/json.hpp Outdated Show resolved Hide resolved
cpp/src/io/json/reader_impl.cu Show resolved Hide resolved
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Nov 11, 2021
@bdice bdice self-requested a review November 11, 2021 16:33
@codecov
Copy link

codecov bot commented Nov 11, 2021 •
edited
Loading

Codecov Report

Merging #9659 (cf42838) into branch-21.12 (ab4bfaa) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9659      +/-   ##
================================================
- Coverage         10.79%   10.67%   -0.12%     
================================================
  Files               116      117       +1     
  Lines             18869    19884    +1015     
================================================
+ Hits               2036     2123      +87     
- Misses            16833    17761     +928
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e4afd1...cf42838. Read the comment docs.

@cwharris
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 36b3344 into rapidsai:branch-21.12 Nov 11, 2021
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuIO Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cwharris @bdice @ttnghia @vyasr