Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add const when getting data from a JNI data wrapper #9637

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

wjxiz1992
Copy link
Member

when calling from a .cu file which will be compiled by nvcc, the following error will be thrown:

/cudf-src/java/src/main/native/include/jni_utils.hpp(331): error: reinterpret_cast cannot cast away const or other type qualifiers

Add the const keyword to get rid of this error.

Signed-off-by: Allen Xu [email protected]

Co-authored-by: Jiaming Yuan [email protected]

Signed-off-by: Allen Xu <[email protected]>

Co-authored-by: Jiaming Yuan <[email protected]>
@wjxiz1992 wjxiz1992 requested a review from a team as a code owner November 9, 2021 14:26
@github-actions github-actions bot added the Java Affects Java cuDF API. label Nov 9, 2021
@wjxiz1992 wjxiz1992 changed the title add const when getting data from a wrapped jni data wrapper add const when getting data from a jni data wrapper Nov 9, 2021
@jlowe jlowe changed the title add const when getting data from a jni data wrapper add const when getting data from a JNI data wrapper Nov 9, 2021
@jlowe jlowe added bug Something isn't working non-breaking Non-breaking change labels Nov 9, 2021
Signed-off-by: Allen Xu <[email protected]>
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #9637 (ec79e3a) into branch-21.12 (ab4bfaa) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head ec79e3a differs from pull request most recent head 86d62c6. Consider uploading reports for the commit 86d62c6 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9637      +/-   ##
================================================
- Coverage         10.79%   10.66%   -0.13%     
================================================
  Files               116      117       +1     
  Lines             18869    19829     +960     
================================================
+ Hits               2036     2115      +79     
- Misses            16833    17714     +881     
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3280be2...86d62c6. Read the comment docs.

@ttnghia
Copy link
Contributor

ttnghia commented Nov 9, 2021

Rerun tests.

@firestarman
Copy link
Contributor

rerun tests

@jlowe
Copy link
Member

jlowe commented Nov 10, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d60e2e6 into rapidsai:branch-21.12 Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants