Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated Rmm.initialize method #9607

Merged
merged 1 commit into from
Nov 4, 2021
Merged

remove deprecated Rmm.initialize method #9607

merged 1 commit into from
Nov 4, 2021

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Nov 4, 2021

@rongou rongou added 3 - Ready for Review Ready for review by team RMM Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Nov 4, 2021
@rongou rongou requested a review from jlowe November 4, 2021 16:34
@rongou rongou self-assigned this Nov 4, 2021
@rongou rongou requested a review from a team as a code owner November 4, 2021 16:34
@rongou rongou added the improvement Improvement / enhancement to an existing function label Nov 4, 2021
@codecov
Copy link

codecov bot commented Nov 4, 2021 •
edited
Loading

Codecov Report

Merging #9607 (5d45f17) into branch-21.12 (ab4bfaa) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 5d45f17 differs from pull request most recent head 4fb153f. Consider uploading reports for the commit 4fb153f to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.12    #9607      +/-   ##
================================================
- Coverage         10.79%   10.66%   -0.13%     
================================================
  Files               116      117       +1     
  Lines             18869    19735     +866     
================================================
+ Hits               2036     2104      +68     
- Misses            16833    17631     +798
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/sorting.py 92.90% <0.00%> (-1.21%) ⬇️
python/cudf/cudf/io/csv.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/__init__.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f041a47...4fb153f. Read the comment docs.

@rongou
Copy link
Contributor Author

rongou commented Nov 4, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 713a3b2 into rapidsai:branch-21.12 Nov 4, 2021
@rongou rongou deleted the remove-deprecated-rmm-init branch November 23, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlowe jlowe jlowe approved these changes

Assignees

@rongou rongou

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rongou @jlowe