-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failure with cuda 11.5 in row_bit_count tests. #9581
Fix test failure with cuda 11.5 in row_bit_count tests. #9581
Conversation
…. Was relying on a quirky compiler behavior with initializer list constructors that has been removed in cuda 11.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
From my experience I had no way to create |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9581 +/- ##
================================================
- Coverage 10.79% 10.65% -0.14%
================================================
Files 116 117 +1
Lines 18869 19743 +874
================================================
+ Hits 2036 2104 +68
- Misses 16833 17639 +806
Continue to review full report at Codecov.
|
@gpucibot merge |
Test code was relying on a quirky (and probably incorrect) compiler behavior where
would produce a
List<List<int>>
column with no rows at the top. With cuda 11.5 the order of constructors causes this to create aList<List<int>>
column with 1 row at the top. This leaveslists_column_wrapper
with no way to currently express "an entirely empty list column nested more than 1 level deep" so the fix for now is just to construct these tests manually.