Fixed tests warning: "TYPED_TEST_CASE is deprecated, please use TYPED_TEST_SUITE" #9574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
3 - Ready for Review
vuule
approved these changes
Nov 1, 2021
nvdbaranec
approved these changes
Nov 9, 2021
# Conflicts: # cpp/tests/reductions/scan_tests.cpp
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9574 +/- ##
================================================
- Coverage 10.79% 10.67% -0.12%
================================================
Files 116 117 +1
Lines 18869 19471 +602
================================================
+ Hits 2036 2078 +42
- Misses 16833 17393 +560
Continue to review full report at Codecov.
|
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 10, 2021
The recent PR #9574 missed updating the docs. This PR fixes that. Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Nghia Truong (https://github.com/ttnghia) - MithunR (https://github.com/mythrocks) URL: #9654
|
Thanks for this change, @ttnghia. I've been correcting my tests only when I run into this during peripheral changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a simple refactoring in the unit tests, replacing the calls to macro
TYPED_TEST_CASEby calling toTYPED_TEST_SUITEmacro instead.This is to fix the warning: "TYPED_TEST_CASE is deprecated, please use TYPED_TEST_SUITE".
Due to high conflict with other PRs, this PR should be merged last, after other C++ PRs, before code freeze.