Fix edge case in tdigest scalar generation for groups containing all nulls. #9551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of nulls, which was causing the tdigest reduce_by_key step to run out of bounds.
nvdbaranec
added
bug
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9551 +/- ##
================================================
- Coverage 10.79% 10.64% -0.15%
================================================
Files 116 117 +1
Lines 18869 19339 +470
================================================
+ Hits 2036 2059 +23
- Misses 16833 17280 +447
Continue to review full report at Codecov.
|
mythrocks
reviewed
Nov 1, 2021
mythrocks
reviewed
Nov 1, 2021
mythrocks
reviewed
Nov 1, 2021
ttnghia
reviewed
Nov 3, 2021
ttnghia
reviewed
Nov 3, 2021
ttnghia
reviewed
Nov 3, 2021
ttnghia
reviewed
Nov 3, 2021
ttnghia
approved these changes
Nov 3, 2021
mythrocks
approved these changes
Nov 3, 2021
|
@gpucibot merge |
mythrocks
reviewed
Nov 4, 2021
| thrust::make_counting_iterator(0), | ||
| _weights->mutable_view().begin<double>(), | ||
| is_stub_weight); | ||
| auto _means = remove_stubs(*means, num_stubs); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the scalar input case, groups containing all nulls would generate empty digests (those with no clusters). However during the final
reduce_by_keycall those values were still getting visited and were therefore expecting a place to store the unused reduced values, which would cause a subsequent overrun later on.The fix is to specifically leave a single "stub" centroid entry for this specific case and then strip them out in a postprocess.